Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix graph kernel attributes update after GPTQ run #1035

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

ofirgo
Copy link
Collaborator

@ofirgo ofirgo commented Apr 8, 2024

Pull Request Description:

Fixing a bug added when attributes quantization was implemented, where after the GPTQ run the threshold parameter of the kernel was not updated correctly.

Also changing the argument names in set_quant_config_attr function, to prevent confusion.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo ofirgo merged commit 934ac82 into sony:main Apr 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants