Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource utilization variable name in Keras tutorial #1020

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

samuel-wj-chapman
Copy link
Contributor

@samuel-wj-chapman samuel-wj-chapman commented Mar 27, 2024

Pull Request Description:

variable fix, line 299

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo
Copy link
Collaborator

ofirgo commented Mar 27, 2024

Can you specify which variable you fixed? It is complicated to understand it the way the .ipynb file is shown.
In general, the PR title should include meaningful content (it will probably appear as the commit message when you'll merge it so the commit message also should be meaningful)

@samuel-wj-chapman
Copy link
Contributor Author

notebook was failing due to a naming mistake.

just one line changed

"    target_ResourceUtilization=ResourceUtilization,\n",

changed to
" target_resource_utilization=resource_utilization,\n",

i am unsure why so much has flagged as changed between the two notebooks sorry if that added confusion

@ofirgo ofirgo changed the title variable fix Fix resource utilization variable name in Keras tutorial Mar 28, 2024
@ofirgo
Copy link
Collaborator

ofirgo commented Mar 28, 2024

notebook was failing due to a naming mistake.

just one line changed

"    target_ResourceUtilization=ResourceUtilization,\n",

changed to " target_resource_utilization=resource_utilization,\n",

i am unsure why so much has flagged as changed between the two notebooks sorry if that added confusion

All good, I meant just edit the PR title so it would be informative.
I edited it now, you can see what I meant.

@samuel-wj-chapman samuel-wj-chapman merged commit a47744d into sony:main Mar 28, 2024
27 checks passed
samuel-wj-chapman added a commit to samuel-wj-chapman/model_optimization that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants