Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ and bag-of-tricks #1006

Merged
merged 7 commits into from
Mar 21, 2024
Merged

Add FAQ and bag-of-tricks #1006

merged 7 commits into from
Mar 21, 2024

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented Mar 19, 2024

Pull Request Description:

Add Bag-of-Tricks and FAQ, with links in readme

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@elad-c elad-c requested review from ofirgo and Idan-BenAmi March 19, 2024 16:20
Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't go over the tricks page itself, but in the meantime, comments on all the rest

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@elad-c elad-c added the documentation Improvements or additions to documentation label Mar 20, 2024
FAQ.md Show resolved Hide resolved
README.md Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Show resolved Hide resolved
quantization_troubleshooting.md Outdated Show resolved Hide resolved
quantization_troubleshooting.md Outdated Show resolved Hide resolved
quantization_troubleshooting.md Show resolved Hide resolved
quantization_troubleshooting.md Outdated Show resolved Hide resolved
quantization_troubleshooting.md Outdated Show resolved Hide resolved
FAQ.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@elad-c elad-c merged commit 5e9d1ba into main Mar 21, 2024
26 of 27 checks passed
@elad-c elad-c deleted the add_bag_of_tricks_and_faq branch March 21, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:exporter documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants