two step circuit breaker #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gobreaker.go
Outdated
| @@ -146,6 +153,13 @@ func NewCircuitBreaker(st Settings) *CircuitBreaker { | |||
| return cb | |||
| } | |||
|
|
|||
| // NewTwoStep returns a new TwoStepCircuitBreaker configured with the given Settings. | |||
There was a problem hiding this comment.
I think it's better to rename NewTwoStep to NewTwoStepCircuitBreaker .
gobreaker_test.go
Outdated
| @@ -52,11 +62,46 @@ func fail(cb *CircuitBreaker) error { | |||
| return err | |||
| } | |||
|
|
|||
| func fail2Step(cb *TwoStepCircuitBreaker) { | |||
There was a problem hiding this comment.
I think fail2Step should return error.
gobreaker_test.go
Outdated
| @@ -211,6 +239,61 @@ func TestCustomCircuitBreaker(t *testing.T) { | |||
| assert.Equal(t, StateChange{"cb", StateHalfOpen, StateClosed}, stateChange) | |||
| } | |||
|
|
|||
| func TestMultiStepBreaker(t *testing.T) { | |||
There was a problem hiding this comment.
I think it's better to rename TestMultiStepBreaker to TestTwoStepCircuitBreaker.
gobreaker_test.go
Outdated
| @@ -211,6 +239,61 @@ func TestCustomCircuitBreaker(t *testing.T) { | |||
| assert.Equal(t, StateChange{"cb", StateHalfOpen, StateClosed}, stateChange) | |||
| } | |||
|
|
|||
| func TestMultiStepBreaker(t *testing.T) { | |||
| cb := &TwoStepCircuitBreaker{cb: defaultCB} | |||
There was a problem hiding this comment.
It's better to use NewTwoStepCircuitBreaker, which improves code coverage.
- renamed twostep breaker constructor - fixed failure test call to return an error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
providing a two-step circuit breaker where checking whether a request can proceed and reporting the otucome is separated.
see previous discussions on the topic in #4