Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Thinkit] Update P4Info configuration API calls. Remove thread-unsafe TryCancel method; migrate users to Finish and make it safe.remove deprecated P4RuntimeSession API.Adds StreamableStatusOr utility and removed absl::StatusOr operator<< overloads. #1024

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ksravani-hcl
Copy link
Contributor

Keyword Check:
/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.

Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Build options --copt, --cxxopt, --host_copt, and 1 more have changed, discarding analysis cache.
INFO: Analyzed 710 targets (0 packages loaded, 22885 targets configured).
INFO: Found 710 targets...
INFO: From Compiling src/google/protobuf/compiler/retention.cc [for host]:
external/com_google_protobuf/src/google/protobuf/compiler/retention.cc: In function 'void google::protobuf::compiler::{anonymous}::StripSourceCodeInfo(std::vector<std::vector >&, google::protobuf::SourceCodeInfo&)':
external/com_google_protobuf/src/google/protobuf/compiler/retention.cc:216:21: warning: comparison of integer expressions of different signedness: 'int' and 'std::vectorgoogle::protobuf::SourceCodeInfo_Location*::size_type' {aka 'long unsigned int'} [-Wsign-compare]
216 |   for (int i = 0; i < old_locations.size(); ++i) {
     |                   ~~^~~~~~~~~~~~~~~~~~~~~~
INFO: From Compiling src/google/protobuf/generated_message_tctable_lite.cc [for host]:
In file included from bazel-out/host/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_lite/google/protobuf/generated_message_tctable_decl.h:45,
                from external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:37:
bazel-out/host/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_lite/google/protobuf/parse_context.h:1150:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
1150 | ParseContext::ParseLengthDelimitedInlined(const char* ptr, const Func& func) {
     | ^~~~~~~~~~~~
external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:871:36: warning: 'always_inline' function might not be inlinable [-Wattributes]
871 | PROTOBUF_ALWAYS_INLINE const char* TcParser::FastVarintS1(
     |                                    ^~~~~~~~
external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:871:36: warning: 'always_inline' function might not be inlinable [-Wattributes]
INFO: From Compiling src/google/protobuf/generated_message_tctable_lite.cc:
In file included from bazel-out/k8-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_lite/google/protobuf/generated_message_tctable_decl.h:45,
                from external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:37:
bazel-out/k8-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_lite/google/protobuf/parse_context.h:1150:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
1150 | ParseContext::ParseLengthDelimitedInlined(const char* ptr, const Func& func) {
     | ^~~~~~~~~~~~
external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:871:36: warning: 'always_inline' function might not be inlinable [-Wattributes]
871 | PROTOBUF_ALWAYS_INLINE const char* TcParser::FastVarintS1(
     |                                    ^~~~~~~~
external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:871:36: warning: 'always_inline' function might not be inlinable [-Wattributes]
INFO: From Compiling src/google/protobuf/compiler/retention.cc:
external/com_google_protobuf/src/google/protobuf/compiler/retention.cc: In function 'void google::protobuf::compiler::{anonymous}::StripSourceCodeInfo(std::vector<std::vector >&, google::protobuf::SourceCodeInfo&)':
external/com_google_protobuf/src/google/protobuf/compiler/retention.cc:216:21: warning: comparison of integer expressions of different signedness: 'int' and 'std::vectorgoogle::protobuf::SourceCodeInfo_Location*::size_type' {aka 'long unsigned int'} [-Wsign-compare]
216 |   for (int i = 0; i < old_locations.size(); ++i) {
     |                   ~~^~~~~~~~~~~~~~~~~~~~~~
INFO: From Compiling p4_pdpi/string_encodings/byte_string.cc:
p4_pdpi/string_encodings/byte_string.cc: In function 'int pdpi::GetBitwidthOfByteString(absl::lts_20230802::string_view)':
external/com_github_grpc_grpc/src/core/ext/transport/chttp2/transport/hpack_parser.cc:534:6: required from here
external/com_github_grpc_grpc/src/core/ext/transport/chttp2/transport/decode_huff.h:2746:52: warning: comparison of integer expressions of different signedness: 'uint64_t' {aka 'long unsigned int'} and 'int' [-Wsign-compare]
INFO: From Compiling src/core/ext/transport/chttp2/transport/chttp2_transport.cc:
In file included from external/com_github_grpc_grpc/src/core/ext/transport/chttp2/transport/hpack_parser.h:43,
from external/com_github_grpc_grpc/src/core/ext/transport/chttp2/transport/internal.h:49,
from external/com_github_grpc_grpc/src/core/ext/transport/chttp2/transport/chttp2_transport.cc:65:
external/com_github_grpc_grpc/src/core/lib/channel/call_tracer.h:45:1: warning: multi-line comment [-Wcomment]
45 | // /
| ^
external/com_github_grpc_grpc/src/core/lib/channel/call_tracer.h:47:1: warning: multi-line comment [-Wcomment]
47 | // /
| ^
INFO: Elapsed time: 460.244s, Critical Path: 32.86s
INFO: 2396 processes: 1 internal, 2395 linux-sandbox

Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 710 targets (0 packages loaded, 378 targets configured).
INFO: Found 488 targets and 222 test targets...
INFO: Elapsed time: 274.298s, Critical Path: 127.10s
INFO: 279 processes: 336 linux-sandbox, 18 local.
INFO: Build completed successfully, 279 total actions
//dvaas:port_id_map_test PASSED in 0.9s
//dvaas:test_run_validation_golden_test PASSED in 0.2s
//dvaas:test_run_validation_test PASSED in 0.8s
//dvaas:test_run_validation_test_runner PASSED in 0.1s
//dvaas:test_vector_stats_diff_test PASSED in 0.1s
//dvaas:test_vector_stats_test PASSED in 0.8s
//dvaas:test_vector_test PASSED in 0.7s
//dvaas:user_provided_packet_test_vector_diff_test PASSED in 0.2s
//dvaas:user_provided_packet_test_vector_test PASSED in 0.4s
//gutil:collections_test PASSED in 0.7s
//gutil:io_test PASSED in 0.6s
//gutil:proto_matchers_test PASSED in 0.9s
//gutil:proto_ordering_test PASSED in 0.7s
//gutil:proto_test PASSED in 1.0s
//gutil:status_matchers_test PASSED in 0.7s
//gutil:test_artifact_writer_test PASSED in 0.7s
//gutil:testing_test PASSED in 1.0s
//gutil:timer_test PASSED in 5.0s
//gutil:version_test PASSED in 1.1s
//lib:basic_switch_test PASSED in 0.9s
//lib:ixia_helper_test PASSED in 1.5s
//lib/basic_traffic:basic_p4rt_util_test PASSED in 1.6s
//p4rt_app/tests:role_test PASSED in 1.7s
//p4rt_app/tests:state_verification_test PASSED in 3.2s
//p4rt_app/tests:vrf_table_test PASSED in 2.7s
//p4rt_app/tests/lib:app_db_entry_builder_test PASSED in 0.0s
//p4rt_app/utils:event_data_tracker_test PASSED in 0.0s
//p4rt_app/utils:table_utility_test PASSED in 0.8s
//sai_p4/instantiations/google:clos_stage_test PASSED in 1.4s
//sai_p4/instantiations/google:fabric_border_router_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test PASSED in 1.0s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 10.3s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 10.7s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 1.0s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 1.2s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.2s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 1.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 1.6s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 1.1s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test PASSED in 3.8s
//sai_p4/tools:p4info_tools_test PASSED in 10.2s
//sai_p4/tools:packetio_tools_test PASSED in 1.2s
//tests:thinkit_gnmi_interface_util_tests PASSED in 1.7s
//tests/forwarding:hash_statistics_util_test PASSED in 1.6s
//tests/lib:p4info_helper_test PASSED in 0.9s
//tests/lib:p4rt_fixed_table_programming_helper_test PASSED in 1.6s
//tests/lib:switch_test_setup_helpers_golden_test PASSED in 0.6s
//tests/lib:switch_test_setup_helpers_golden_test_runner PASSED in 0.1s
//tests/qos:gnmi_parsers_test PASSED in 0.1s
//tests/qos:gnmi_parsers_test_runner PASSED in 0.0s
//tests/sflow:sflow_util_test PASSED in 8.8s
//thinkit:bazel_test_environment_test PASSED in 0.7s
//thinkit:generic_testbed_test PASSED in 1.0s
//thinkit:mock_control_device_test PASSED in 0.7s
//thinkit:mock_generic_testbed_test PASSED in 0.8s
//thinkit:mock_mirror_testbed_test PASSED in 1.0s
//thinkit:mock_ssh_client_test PASSED in 0.1s
//thinkit:mock_switch_test PASSED in 1.0s
//thinkit:mock_test_environment_test PASSED in 0.1s
//thinkit:switch_test PASSED in 0.8s
//tests/lib:packet_generator_test PASSED in 60.7s
Stats over 4 runs: max = 60.7s, min = 57.4s, avg = 58.9s, dev = 1.3s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 1.0s
Stats over 5 runs: max = 1.0s, min = 0.7s, avg = 0.8s, dev = 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 47.6s
Stats over 50 runs: max = 47.6s, min = 0.8s, avg = 4.2s, dev = 10.8s

Executed 222 out of 222 tests: 222 tests pass.
INFO: Build completed successfully, 279 total actions

kishanps and others added 6 commits February 19, 2025 16:55
…ns. Add AclDeny to ingress security table and check if the packets get dropped. Update to push a SUT P4Info if given one.Remove `if (!params.punt_action.has_value())` in acl_feature_test. Make rewrites explicit in ACL feature test.Add a test to match on src_mac in AclEgressTable
…otOk test due to fixed bug.Support platforms that do not support GRE tunnels. Add test checking that the switch will tolerate unicast routes with multicast dst IPs.Fix update ordering to allow proper fail-on-first.
… TryCancel method; migrate users to Finish and make it safe.remove deprecated P4RuntimeSession API.Adds `StreamableStatusOr` utility and removed `absl::StatusOr` `operator<<` overloads.
@mssonicbld
Copy link

/azp run

Copy link

No pipelines are associated with this pull request.

@ksravani-hcl
Copy link
Contributor Author

Co-authored-by: Srikishen Pondicherry Shanmugam [email protected]
Co-authored-by: Steffen Smolka [email protected]
Co-authored-by: Jonathan Dilorenzo [email protected]
Co-authored-by: rhalstea [email protected]
Co-authored-by:Zie Weaver [email protected]

Copy link

@jaanah-hcl jaanah-hcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kishanps Kindly review the PR
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants