Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests: Fixed compile error in Divide test with newer Apple Clang #127

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JanosGit
Copy link
Member

I ran into a compile error here when attempting to build the unit tests with a recent Xcode version. Seems like the compiler attempted to instantiate the function template with some invalid types. The lambdas with explicit argument types fixed it.

@JanosGit JanosGit requested a review from iromur March 28, 2024 15:48
Copy link
Contributor

@iromur iromur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really strange. Aren't other arithmetic tests done in the same way?

Another question: Are the unit test failures on Linux related or for another time?

@JanosGit
Copy link
Member Author

JanosGit commented Apr 2, 2024

From what I get this is caused by some explicitly overloaded operator/ definitions from the Xcode 15 standard library. Unfortunately, the change which fixes the macOS build now explicitly breaks the Linux build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants