Add compatibility with Symfony 6 #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
force-pushed
the
feature/symfony-6
branch
from
f58dbcb to
c9df637
Compare
|
Depends on this: doctrine/mongodb-odm#2370 |
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
feature/symfony-6
branch
from
9180093 to
402e1ad
Compare
36 tasks
|
Could you please rebase your PR and fix merge conflicts? |
|
Restarting the build |
|
It needs mongodb to be released, otherwise it will prioritize stable release over dev ones |
|
The build didn't restart 😕 the failing job looks like it is trying the dev version (the mongodb-odm release is scheduled at the end of november), maybe rebasing? |
jordisala1991
force-pushed
the
feature/symfony-6
branch
from
402e1ad to
b6d7469
Compare
|
It is not blocked anymore. Yay! Thanks @franmomu for adding compat on mongodb side |
franmomu
approved these changes
Oct 24, 2021
VincentLanglet
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is BC.
Part of: sonata-project/dev-kit#1675
Dev-kit PR: sonata-project/dev-kit#1734
Changelog