Increase Psalm to level 2 #1528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
force-pushed
the
hotfix/increase-psalm-2
branch
from
6ea9159 to
dc4c3e2
Compare
VincentLanglet
requested changes
Aug 8, 2022
| @@ -91,6 +96,9 @@ protected function configureRoutes($routes): void | |||
| $routes->import($this->getProjectDir().'/config/routes.yaml'); | |||
| } | |||
|
|
|||
| /** | |||
| * @psalm-suppress DeprecatedClass | |||
There was a problem hiding this comment.
We didn't add it on other bundles. This method is rather simple, it will be removed once SonataBlock bundle is version 5 only.
jordisala1991
force-pushed
the
hotfix/increase-psalm-2
branch
from
dc4c3e2 to
f953e82
Compare
jordisala1991
force-pushed
the
hotfix/increase-psalm-2
branch
from
f953e82 to
65e21ed
Compare
VincentLanglet
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this can only be applied to 4.x.
Changelog