Fix tests (#1527)

sonata-project · Aug 7, 2022 · c7b1889 · c7b1889
1 parent 37ce8fd
commit c7b1889
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 16 deletions.
diff --git a/tests/CmsManager/CmsPageManagerTest.php b/tests/CmsManager/CmsPageManagerTest.php
@@ -97,15 +97,15 @@ public function testGetPageWithUrl(): void
     {
         $pageManager = $this->createMock(PageManagerInterface::class);
 
-        $pageManager->method('findOneBy')->willReturn(new Page());
+        $page = new Page();
+        $page->setId(42);
+        $pageManager->method('findOneBy')->willReturn($page);
         $this->blockInteractor->method('loadPageBlocks')->willReturn([]);
 
         $manager = $this->createManager($pageManager, $this->blockInteractor);
 
-        $page = '/test';
         $site = new Site();
-
-        static::assertInstanceOf(PageInterface::class, $manager->getPage($site, $page));
+        static::assertInstanceOf(PageInterface::class, $manager->getPage($site, '/test'));
     }
 
     /**
@@ -138,15 +138,15 @@ public function testGetPageWithRouteName(): void
     {
         $pageManager = $this->createMock(PageManagerInterface::class);
 
-        $pageManager->method('findOneBy')->willReturn(new Page());
+        $page = new Page();
+        $page->setId(42);
+        $pageManager->method('findOneBy')->willReturn($page);
         $this->blockInteractor->method('loadPageBlocks')->willReturn([]);
 
         $manager = $this->createManager($pageManager, $this->blockInteractor);
 
-        $page = 'test';
         $site = new Site();
-
-        static::assertInstanceOf(PageInterface::class, $manager->getPage($site, $page));
+        static::assertInstanceOf(PageInterface::class, $manager->getPage($site, 'test'));
     }
 
     /**
@@ -179,15 +179,15 @@ public function testGetPageWithId(): void
     {
         $pageManager = $this->createMock(PageManagerInterface::class);
 
-        $pageManager->method('findOneBy')->willReturn(new Page());
+        $page = new Page();
+        $page->setId(42);
+        $pageManager->method('findOneBy')->willReturn($page);
         $this->blockInteractor->method('loadPageBlocks')->willReturn([]);
 
         $manager = $this->createManager($pageManager, $this->blockInteractor);
 
-        $page = 1;
         $site = new Site();
-
-        static::assertInstanceOf(PageInterface::class, $manager->getPage($site, $page));
+        static::assertInstanceOf(PageInterface::class, $manager->getPage($site, 1));
     }
 
     /**
@@ -220,15 +220,16 @@ public function testGetPageWithoutParam(): void
     {
         $pageManager = $this->createMock(PageManagerInterface::class);
 
-        $pageManager->method('findOneBy')->willReturn(new Page());
+        $page = new Page();
+        $page->setId(42);
+        $pageManager->method('findOneBy')->willReturn($page);
         $this->blockInteractor->method('loadPageBlocks')->willReturn([]);
 
         $manager = $this->createManager($pageManager, $this->blockInteractor);
         $manager->setCurrentPage(new Page());
-        $page = null;
-        $site = new Site();
 
-        static::assertInstanceOf(PageInterface::class, $manager->getPage($site, $page));
+        $site = new Site();
+        static::assertInstanceOf(PageInterface::class, $manager->getPage($site, null));
     }
 
     /**

diff --git a/tests/CmsManager/CmsSnapshotManagerTest.php b/tests/CmsManager/CmsSnapshotManagerTest.php
@@ -114,6 +114,7 @@ public function testGetPageWithId(): void
         $pBlock->addChild($cBlock);
         $pBlock->setId(1);
 
+        $page->method('getId')->willReturn(42);
         $page->method('getBlocks')->willReturn([$pBlock]);
 
         $this->snapshotManager