Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: form validations are by passed when an Exception is thrown #1218

Merged
merged 1 commit into from
Feb 5, 2025
Merged

fix: form validations are by passed when an Exception is thrown #1218

merged 1 commit into from
Feb 5, 2025

Conversation

sad270
Copy link
Contributor

@sad270 sad270 commented Oct 25, 2024

Subject

fix: form validations are by passed when an Exception is thrown

I am targeting this branch, because it is a fix.

Closes #1217

Changelog

### Fixed
- fix: form validations are by passed when an Exception is thrown

To do

  • Update the tests;

@sad270 sad270 mentioned this pull request Oct 25, 2024
Closed
@VincentLanglet VincentLanglet reopened this Feb 5, 2025
@VincentLanglet VincentLanglet merged commit 4eca9f8 into sonata-project:5.x Feb 5, 2025
21 of 22 checks passed
@sad270 sad270 deleted the fix/1217/by-pass-form-validation-when-exception branch February 5, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Form validations of Block are bypassed when an Exception is thrown
2 participants
@sad270 @VincentLanglet