Add extension paths before initialize_cache
#71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidus_support v0.9.0, released on May 26, 2022, included a commit that fixes the load order of adding extension paths. See solidusio@202e77c. The commit depends on the `initialize_dependency_mechanism` Rails initializer (https://github.com/rails/rails/blob/127dd06df66552dd272eea7832f8bb205cf6fd01/railties/lib/rails/application/bootstrap.rb#L68). However, that initiliazer was removed in Rails 7.0.3 (rails/rails@0375657). The extension paths initializer has been updated to run before `initialize_cache`. `initialize_cache` runs 1) after the Solidus engines have already loaded BUT 2) before Rails has added the paths to `$LOAD_PATH`. Normally, it would be sufficient to run the initializer before the `set_load_path` initializer. However, external gems such as Deface may also change the load paths before `set_load_path`. To ensure that our extension paths are not affected by those gems, we work around those gems by adding our paths before `initialize_cache`, which is the Rails initializer called before `set_load_path`. References ---------- * `bin/rails initializers` - Shows list of active initializers * List of Rails initializers: https://guides.rubyonrails.org/configuring.html#initializers * Engine paths configuration - See Paths section in https://api.rubyonrails.org/v7.0.3/classes/Rails/Engine.html.
gsmendoza
force-pushed
the
gsmendoza/eng-344-fix-actionviewmissingtemplate-errors-on
branch
from
e4675a9 to
12c970e
Compare
waiting-for-dev
approved these changes
Jun 1, 2022
aldesantis
approved these changes
Jun 1, 2022
MassimilianoLattanzio
added a commit
to sdtechdev/solidus_support
that referenced
this pull request
May 10, 2024
In solidusio#65 and solidusio#71 they changed how the engine i loaded using the Rails initializers. This updates causes some issues when using Rails <6.1 because the initializers are totally different. The solution is to load the extension outside of the initializer block until we use Rails 6.1 or newer version. Ref: solidusio#73.
MassimilianoLattanzio
added a commit
to sdtechdev/solidus_support
that referenced
this pull request
May 10, 2024
In solidusio#65 and solidusio#71 they changed how the engine is loaded using the Rails initializers. This updates causes some issues when using Rails < 6.1 because the initializers are totally different. The solution is to load the extension outside of the initializer block until we use Rails 6.1 or newer version. Ref: solidusio#73.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solidus_support v0.9.0, released on May 26, 2022, included a commit that fixes
the load order of adding extension paths. See
202e77c.
The commit depends on the
initialize_dependency_mechanismRails initializer(https://github.com/rails/rails/blob/127dd06df66552dd272eea7832f8bb205cf6fd01/railties/lib/rails/application/bootstrap.rb#L68).
However, that initiliazer was removed in Rails 7.0.3
(rails/rails@0375657).
The extension paths initializer has been updated to run before
initialize_cache.initialize_cacheruns 1) after the Solidus engines havealready loaded BUT 2) before Rails has added the paths to
$LOAD_PATH.Normally, it would be sufficient to run the initializer before the
set_load_pathinitializer. However, external gems such as Deface may alsochange the load paths before
set_load_path. To ensure that ourextension paths are not affected by those gems, we work around those gems by
adding our paths before
initialize_cache, which is the Rails initializercalled before
set_load_path.References
bin/rails initializers- Shows list of active initializersTesting
Tested on SolidusPaypalCommercePlatform: