Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to check if combined address name is being used #58

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

kennyadsl
Copy link
Member

This helper method checks if a store is using the old or new way of setting the address' name.

It will act as a migration support to create conditional code to make extensions work compatible with both versions.

We can remove this method when the last 2.x version will reach EOL.

cc @filippoliverani

To be able to have a working console. For some reason it's not
loading Rails correctly, some pieces are missing.
@kennyadsl kennyadsl requested a review from aldesantis January 19, 2021 08:44
@kennyadsl kennyadsl self-assigned this Jan 19, 2021
@kennyadsl kennyadsl changed the title Add a method to check if combined name is being used Add a method to check if combined address name is being used Jan 19, 2021
This helper method checks if a store is using the old or new
way of setting address' name.

It will act as a migration support to create conditional code
to make extensions work compatible with both versions.

We can remove this method when the last 2.x version will reach EOL.
@kennyadsl kennyadsl force-pushed the kennyadsl/check-address branch from d884114 to 4f3ccab Compare January 19, 2021 11:01
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennyadsl thanks 👍

@kennyadsl kennyadsl merged commit 7cc4718 into master Jan 19, 2021
@kennyadsl kennyadsl deleted the kennyadsl/check-address branch January 19, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants