Update gem with the latest dev_support #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with
solidus extension .
Co-authored-by: Rainer Dema <[email protected]>
kennyadsl
force-pushed
the
kennyadsl+rainerdema/update-latest-dev-support
branch
from
509c3ad to
9b7547d
Compare
This gem is not ready for Rubocop linting and making it ready is not part of this PR scope.
kennyadsl
force-pushed
the
kennyadsl+rainerdema/update-latest-dev-support
branch
2 times, most recently
from
0ba70c2 to
e8cfd15
Compare
jarednorman
approved these changes
Jan 24, 2021
aldesantis
approved these changes
Jan 25, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
Specs are failing in master but it's expected because this is not yet compatible with Solidus 3.0. We have another PR open for that #99, but we need this one to be merged before.