Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum solidus_support version requirement #102

Conversation

filippoliverani
Copy link
Contributor

@filippoliverani filippoliverani commented Feb 5, 2021

This PR bumps solidus_support minumum required version to 0.8 because SolidusSupport::combined_first_and_last_name_in_address? helper is used in production code and has been implemented in that version.

@filippoliverani filippoliverani force-pushed the filippoliverani/bump-solidus-support branch from 14014c0 to 9a9220f Compare February 5, 2021 16:31
@filippoliverani filippoliverani marked this pull request as ready for review February 5, 2021 17:32
SolidusSupport::combined_first_and_last_name_in_address? helper requires
SolidusSupport >= 0.8 to work
@filippoliverani filippoliverani force-pushed the filippoliverani/bump-solidus-support branch from 9a9220f to 7ea5443 Compare February 5, 2021 19:41
Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spaghetticode spaghetticode merged commit f0f2541 into solidusio:master Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants