Call super from set_user_language #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows reusing the existing implementation in Solidus's `controller_helpers/common`, which is in some ways better than the implementation here. This also removes the prepend_before_action, since it is already added as a before_action in Solidus itself.
tvdeyen
reviewed
Mar 2, 2018
|
@tvdeyen what's your concern with Solidus < 1.3? |
|
@kennyadsl it breaks for Soliuds < 1.3 because it does not have |
|
it looks like it does, maybe it's loaded in a different way? |
|
Got it, in 1.2 those methods were inside the |
|
I don’t think it’s worth to support Solidus < 1.3. It will reach end of life soon and for users of old versions of Solidus there are still older version of this gem. |
|
I think this might be made unnecessary by some of the work in solidusio/solidus#2559. My goal is to move most of |
|
Closed by #2626 🎉 🎉 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows reusing the existing implementation in Solidus's
controller_helpers/common, which is in some ways better than the implementation here.This also removes the
prepend_before_action, since it is already added as abefore_actionin Solidus itself.