Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure solidus_chrome_headless as capybara-screenshot driver #190

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 7, 2022

We have a custom driver. Capybara-screenshot needs to know about it.

Should fix errors like this

Monosnap 2022-09-07 17-48-50

Checklist

  • I have structured the commits for clarity and conciseness.
  • I have added relevant automated tests for this change.

We have a custom driver. Capybara-screenshot needs to know
about it.
@mergify
Copy link
Contributor

mergify bot commented Sep 7, 2022

It looks like this PR is missing a label to determine the type of change it introduces. The maintainer should add one of the following labels:

  • bug for bugfixes.
  • enhancement for new features and improvements.
  • documentation for documentation changes.
  • security for security patches.
  • removed for feature removals.
  • infrastructure for internal changes that should not go in the changelog.

Additionally, the maintainer may also want to add one of the following:

  • breaking for breaking changes.
  • deprecated for feature deprecations.

Once the correct labels have been set, simply remove the needs changelog label label from this PR so I can merge it.

@mergify mergify bot added the needs changelog label Needs a label to determine the type of change. label Sep 7, 2022
@elia elia added enhancement Improves an existing feature. and removed needs changelog label Needs a label to determine the type of change. labels Sep 7, 2022
Have all capybara setup files in one place.
Copy link
Member

@elia elia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📸 👍

@mergify mergify bot merged commit 07737e3 into solidusio:master Sep 8, 2022
@tvdeyen tvdeyen deleted the fix-screenshot-driver branch September 8, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants