Allow using auth_devise with discard #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
force-pushed
the
kennyadsl/migrate-to-discard
branch
2 times, most recently
from
a47f92c to
6e96064
Compare
paranoia is not required anymore since 3.0 ships without it. Who is using older versions of Solidus will see the deprecation as the rest of the paranoia code in core.
kennyadsl
force-pushed
the
kennyadsl/migrate-to-discard
branch
from
6e96064 to
11b9fa9
Compare
jarednorman
approved these changes
Apr 21, 2021
|
@spaghetticode can this be merged, please? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
paranoiais not required anymore since Solidus 3.0 ships without it.Who is using older versions of Solidus will see the deprecation as the rest of the paranoia code in core.
This change requires a release with a major bump, since despite the deprecation warning it could be breaking.