Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax Ruby required version to support Ruby 3.0+ #203

Merged

Conversation

filippoliverani
Copy link
Contributor

This PR removes Ruby version upper limit in gemspec to make the gem work with Ruby 3.0

@filippoliverani filippoliverani marked this pull request as ready for review January 15, 2021 16:00
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kennyadsl kennyadsl requested a review from a team January 19, 2021 10:39
@peterberkenbosch
Copy link
Contributor

One little thing to point out (or maybe new PR?) is to bump the Solidus version in the gemspec to not be <3 so this works on Solidus master (3.0.0.beta) as well.

master...peterberkenbosch:ruby-3-support

@peterberkenbosch
Copy link
Contributor

add Solidus 3 support here #205

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filippoliverani thank you!

@spaghetticode spaghetticode merged commit fa3db0e into solidusio:master Jan 19, 2021
@spaghetticode spaghetticode deleted the filippoliverani/relax-ruby-version branch January 19, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants