Remove admin orders controller specs #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These authentication concerns are already covered by specs in Core. This may have sense in the past, when we have a decorator in place for that controller, but it has been removed with 1a0f531. One of these specs was also failing due to some recent change in core solidusio/solidus#3728, showing the fragility of the approach.
aldesantis
approved these changes
Oct 5, 2020
jarednorman
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These authentication concerns are already covered by specs in Core. This might have a sense in the past when we have a
decorator in place for that controller, but it has been removed with 1a0f531.
One of these specs was also failing due to some recent change in core solidusio/solidus#3728, showing the fragility of the
approach.