Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chrome warnings #187

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Fix chrome warnings #187

merged 1 commit into from
Apr 16, 2020

Conversation

coorasse
Copy link
Contributor

Chrome was raising a warning for missing autocomplete attributes.
See: https://www.chromium.org/developers/design-documents/create-amazing-password-forms

@coorasse
Fix chrome warnings
2b43b4e 
Chrome was raising a warning for missing autocomplete attributes.
See: https://www.chromium.org/developers/design-documents/create-amazing-password-forms
kennyadsl
kennyadsl approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do we need something similar for the other devise forms (registration, forgot password, change password)?

@aldesantis aldesantis merged commit 03d16cf into solidusio:master Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

@aldesantis aldesantis aldesantis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coorasse @kennyadsl @aldesantis