Fill address names combined when needed #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldesantis
requested changes
Mar 16, 2020
kennyadsl
force-pushed
the
kennyadsl/feature-specs-fill-address
branch
2 times, most recently
from
9c6dea1 to
7b4b2a7
Compare
aldesantis
approved these changes
Mar 16, 2020
We introduced a new preference in Solidus core that allows to use the combined version of firstname/lastname. This commit updates checkout feature specs to reflect this preference. Once the split version will be deprecated and removed, we can probably also revert this commit and use the combined version only.
kennyadsl
force-pushed
the
kennyadsl/feature-specs-fill-address
branch
from
7b4b2a7 to
3d92726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a new preference in Solidus core that allows using the combined version of
firstname/lastname.This PR updates checkout feature specs to reflect this preference.
Once the split version will be deprecated and removed, we can probably also revert this commit and use the combined version only.