Fixes for Zeitwerk #176
Merged
Fixes for Zeitwerk #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not compatible with Zeitwerk, which is shipped with Rails 6. Since they are not used in Solidus versions that are compatible with Rails 6, there's no reason to keep them.
tvdeyen
approved these changes
Oct 8, 2019
kennyadsl
force-pushed
the
kennyadsl/zeitwerk-fixes
branch
from
b962a0c to
78c8fdb
Compare
This file has not a class defined with the same name as the filename itself. Zeitwerk does not like it.
With this PR we changed things that makes the extension no more compatible with Solidus < 2.5 and we need to reflect this in the gemspec.
kennyadsl
force-pushed
the
kennyadsl/zeitwerk-fixes
branch
from
78c8fdb to
329f89d
Compare
spaghetticode
approved these changes
Oct 11, 2019
| @@ -21,7 +21,7 @@ Gem::Specification.new do |s| | |||
| s.require_path = "lib" | |||
| s.requirements << "none" | |||
|
|
|||
| solidus_version = [">= 1.2.0", "< 3"] | |||
| solidus_version = [">= 2.6", "< 3"] | |||
jacobherrington
approved these changes
Oct 11, 2019
|
@kennyadsl instead of making overrides compliant with Zeitwerk, I think we should simply prevent Zeitwerk from loading them in the first place: config.eager_load_paths -= %W(#{config.root}/app/overrides)Deface will still load them manually, so this won't create any problems. Furthermore, it's also what @fxn suggests to do (rails/rails#36100 (comment)). |
|
@aldesantis added the proposed solution directly into Deface with a fix: spree/deface#202 which has now been released. I'll re-run specs here and we should be good to merge. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In production, we are experiencing issues with this extension and Zeitwerk, due to how it works and how we named filenames and classes (they should match). See #174
This PR fixes the issue by removing some deface overrides that are no longer needed (since they only apply to Solidus <= 2.5, currently EOL). Also, this PR reorganize some classes that use
class_evalin favor ofModule#prepend, which allows us to define a module that has the same name as the file.A version bump will probably follow this PR.