Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI builds #165

Closed
wants to merge 3 commits into from
Closed

Conversation

aitbw
Copy link
Contributor

@aitbw aitbw commented Aug 2, 2019

This PR fixes the failing CI builds by adding selenium-webdriver as a development dependency (for CircleCI), and specifying DB services / enabling chromedriver (for TravisCI)

It also removes poltergeist as it's not being used anymore.

It also removes Poltergeist as it is not required anymore
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks @aitbw!

Copy link
Member

@spaghetticode spaghetticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aitbw thank you for helping 👍

@spaghetticode
Copy link
Member

@aitbw as Travis is still in use, I think it would be better to fix that build as well before merging the PR. Would you please add a commit for that? I think that these changes in .travis.yml would do:

services:
  - postgresql
  - mysql

thank you! 🙏

@aitbw
Copy link
Contributor Author

aitbw commented Aug 2, 2019

Done @spaghetticode! Thanks for the heads-up 😸

@kennyadsl
Copy link
Member

I think we can disable Travis at all at this point, WDYT?

@spaghetticode
Copy link
Member

@kennyadsl I agree, especially since it's still failing.

@aitbw
Copy link
Contributor Author

aitbw commented Aug 6, 2019

@kennyadsl, I don't have any problems with it. Let me know if you'd like to submit a PR to remove Travis 🙌

@kennyadsl kennyadsl mentioned this pull request Aug 8, 2019
@aitbw aitbw deleted the aitbw/add-selenium-as-dep branch August 9, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants