-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI builds #165
Fix CI builds #165
Conversation
It also removes Poltergeist as it is not required anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thanks @aitbw!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aitbw thank you for helping 👍
@aitbw as Travis is still in use, I think it would be better to fix that build as well before merging the PR. Would you please add a commit for that? I think that these changes in
thank you! 🙏 |
Done @spaghetticode! Thanks for the heads-up 😸 |
I think we can disable Travis at all at this point, WDYT? |
@kennyadsl I agree, especially since it's still failing. |
@kennyadsl, I don't have any problems with it. Let me know if you'd like to submit a PR to remove Travis 🙌 |
This PR fixes the failing CI builds by adding
selenium-webdriver
as a development dependency (for CircleCI), and specifying DB services / enablingchromedriver
(for TravisCI)It also removes
poltergeist
as it's not being used anymore.