Use secret_key_base for Rails 6 compatibility #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
spaghetticode
approved these changes
Jun 21, 2019
kennyadsl
approved these changes
Jun 24, 2019
secret_token has been removed in Rails 6 in favor of secret_key_base. Because we don't want to break authentication for old apps, we use secret_token when both configuration options are available and secret_token is present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
secret_tokenis not available in Rails 6 anymore, it was removed in favor ofsecret_key_base.With this PR, we adopt
secret_key_baseas the pepper when it's available, ensuring compatibility with Rails 6.secret_tokenis still used when available, in order to avoid breaking authentication for existing apps.