Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo of french locale #135

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Fix typo of french locale #135

merged 1 commit into from
Dec 26, 2018

Conversation

imfaruk
Copy link

@imfaruk imfaruk commented Dec 19, 2018 •
edited
Loading

Whenever not_saved key was being called following exception was being raised

ActionView::Template::Error: missing interpolation argument :ressource in "1 erreur interdit cette %{ressource} d'être enregistrée :" ({:count=>1, :resource=>"utilisateur"} given)

This PR fixes the variable interpolation.

Fix typo of frech locale
fcb96ce 
Whenever `not_saved` key was being called following exception was being raised
```
I18n::MissingInterpolationArgument: missing interpolation argument :ressource in "1 erreur interdit cette %{ressource} d'être enregistrée :" ({:count=>1, :resource=>"utilisateur"} given) (Most recent call first)
```
@imfaruk imfaruk changed the title Fix typo of frech locale Fix typo of french locale Dec 19, 2018
jacobherrington
jacobherrington approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je ne suis pas très bon en français mais LGTM! Thanks! 🇫🇷

ericsaupe
ericsaupe approved these changes Dec 19, 2018
View reviewed changes
Copy link

@ericsaupe ericsaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobherrington jacobherrington merged commit b1b94e5 into solidusio:master Dec 26, 2018
@imfaruk imfaruk deleted the fr-translation-fix branch December 27, 2018 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsaupe ericsaupe ericsaupe approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imfaruk @ericsaupe @jacobherrington