Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match logout route to devise configuration #103

Merged
merged 1 commit into from
Jul 25, 2017
Merged

match logout route to devise configuration #103

merged 1 commit into from
Jul 25, 2017

Conversation

BenMorganIO
Copy link
Contributor

@BenMorganIO BenMorganIO commented Jul 18, 2017 •
edited
Loading

Noticed that when I did:

Devise.setup do |config|
  config.sign_out_via = :delete
end

Things wouldn't work when I logged out and the DELETE /logout route didn't exist. This PR makes the routes in Solidus Auth Devise more closely adhere to what is also configured for Devise as well.

@jhawthorn jhawthorn merged commit ac6eb84 into solidusio:master Jul 25, 2017
@jhawthorn
Copy link
Contributor

Thanks Ben

@BenMorganIO BenMorganIO deleted the match-logout-to-devise-config branch July 31, 2017 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennyadsl kennyadsl kennyadsl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenMorganIO @jhawthorn @kennyadsl