The rename! #1
Merged
The rename! #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| Gem::Specification.new do |s| | ||
| s.platform = Gem::Platform::RUBY | ||
| s.name = "solidus_auth_devise" | ||
| s.version = "2.4.0" |
There was a problem hiding this comment.
do we want to re-version this at 1.0.0?
There was a problem hiding this comment.
I think that makes sense.
|
👍 |
Couple of minor tweaks needed to get the tests to pass due to some differences in what Solidus expects. (Mostly that a confirm step is now standard.)
Should use ERB formatting for ERB code. Otherwise it looks silly!
Don't need it in an engine!
They're only used by the tests, so who cares?
spaghetticode
pushed a commit
to spaghetticode/solidus_auth_devise
that referenced
this pull request
Jan 31, 2019
Improve edit user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.