[RFC] Add per-store configurable locales #2627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 13, 2018
| @@ -0,0 +1,7 @@ | |||
| class AddAvailableLocalesToStores < ActiveRecord::Migration[5.1] | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
houndci-bot
reviewed
Mar 13, 2018
| @@ -0,0 +1,7 @@ | |||
| class AddAvailableLocalesToStores < ActiveRecord::Migration[5.1] | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
houndci-bot
reviewed
Mar 13, 2018
| @@ -0,0 +1,7 @@ | |||
| class AddAvailableLocalesToStores < ActiveRecord::Migration[5.1] | |||
There was a problem hiding this comment.
Missing magic comment # frozen_string_literal: true.
This allows storing an array of available locales per-Store. An empty array, or nil, is interpreted as allowing all locales on a store. This is the default.
jhawthorn
force-pushed
the
per_store_locales
branch
from
ac3139d to
06772db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of
#2626and#2559This attempts to replicate the feature added to solidus_i18n in solidusio/solidus_i18n#95. I think this is a feature which we might as well support by default, and I think the implementation is simplified by implementing it in core rather than an extension.
This is just the last two commits here (but relies on features from my other open i18n-related PRs)
cc @DanielePalombo @kennyadsl