Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update solidus behaviour for record not found #76

Merged
merged 1 commit into from
Nov 13, 2017
Merged

update solidus behaviour for record not found #76

merged 1 commit into from
Nov 13, 2017

Conversation

ccarruitero
Copy link
Contributor

Since solidusio/solidus#2329, solidus not handle record not found exception. So update to this behavior to get build passing

@mamhoff
Copy link
Contributor

mamhoff commented Nov 10, 2017

This fixes the spec only for the master branch. Can you either pend the spec for older versions or keep the old version for them? See SolidusSupport gem.

@ccarruitero
Copy link
Contributor Author

I just updated the PR accordingly.

@mamhoff mamhoff merged commit dfbd990 into solidusio-contrib:master Nov 13, 2017
@ccarruitero ccarruitero deleted the fix_specs branch March 19, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff mamhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccarruitero @mamhoff