This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Update new extensions template #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be needed to setup CI correctly and implement other logic based on the Solidus version
houndci-bot
reviewed
Oct 3, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Unable to find gem relaxed-rubocop; is the gem installed? Gem::MissingSpecError
Unable to find gem relaxed-rubocop; is the gem installed? Gem::MissingSpecError /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:189:in `rescue in gem_config_path' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:185:in `gem_config_path' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:47:in `block (2 levels) in resolve_inheritance_from_gems' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:45:in `each' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:45:in `block in resolve_inheritance_from_gems' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:38:in `each_pair' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:38:in `resolve_inheritance_from_gems' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader.rb:48:in `load_file' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader.rb:83:in `configuration_from_file' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_store.rb:44:in `for' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/cli.rb:181:in `apply_default_formatter' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/cli.rb:40:in `run' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/bin/rubocop:13:in `block in ' /home/.asdf/installs/ruby/2.5.1/lib/ruby/2.5.0/benchmark.rb:308:in `realtime' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/bin/rubocop:12:in `' /home/.asdf/installs/ruby/2.5.1/bin/rubocop:23:in `load' /home/.asdf/installs/ruby/2.5.1/bin/rubocop:23:in `'
jacobherrington
approved these changes
Oct 3, 2018
| @@ -5,4 +5,20 @@ bundler_args: --quiet | |||
| script: | |||
| - bundle exec rake | |||
| rvm: | |||
| - 2.1.5 | |||
| - 2.5.1 | |||
tvdeyen
approved these changes
Oct 3, 2018
This is needed to avoid incompatibilities between this extension and old versions of solidus (< 2.5). This can be reverted when Solidus 2.4 reaches EOL. See solidusio/solidus#2835
This allows to install only the version of the database needed. Also, removes sqlite3, since postgres will be the default instead. Please remember that this is just a template (what we do more frequently) but it can be changed anytime by the extension developer.
Maybe we should find a way to make this dynamic?
kennyadsl
force-pushed
the
update-extension-template
branch
from
21bc49d to
9bc3481
Compare
houndci-bot
reviewed
Oct 3, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Unable to find gem relaxed-rubocop; is the gem installed? Gem::MissingSpecError
Unable to find gem relaxed-rubocop; is the gem installed? Gem::MissingSpecError /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:189:in `rescue in gem_config_path' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:185:in `gem_config_path' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:47:in `block (2 levels) in resolve_inheritance_from_gems' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:45:in `each' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:45:in `block in resolve_inheritance_from_gems' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:38:in `each_pair' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader_resolver.rb:38:in `resolve_inheritance_from_gems' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader.rb:48:in `load_file' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_loader.rb:83:in `configuration_from_file' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/config_store.rb:44:in `for' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/cli.rb:181:in `apply_default_formatter' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/lib/rubocop/cli.rb:40:in `run' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/bin/rubocop:13:in `block in ' /home/.asdf/installs/ruby/2.5.1/lib/ruby/2.5.0/benchmark.rb:308:in `realtime' /home/.asdf/installs/ruby/2.5.1/lib/ruby/gems/2.5.0/gems/rubocop-0.54.0/bin/rubocop:12:in `' /home/.asdf/installs/ruby/2.5.1/bin/rubocop:23:in `load' /home/.asdf/installs/ruby/2.5.1/bin/rubocop:23:in `'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to solidusio/solidus#2835 but it also updates the new extensions template to reflect what we are actually doing for the majority of Solidus extensions.