Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created PR to the lang pt #4

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Conversation

brunommpreto
Copy link
Collaborator

Fixed typo in the README file
Added maintainers for the Portuguese(pt) language

@brunommpreto
Copy link
Collaborator Author

The other maintainer is Brazilian should we do it "pt.json" or "pt-br.json".
The doubt came from a previous comment on the issue '#10119'

@franzihei
Copy link
Contributor

Hi @brunommpreto,
Sorry for the late reply, for some reason I didn't get notified or didn't see this. :(
I think it's fine to go with pt.json for now. Let me know if you have any questions in the process.

@franzihei franzihei merged commit 1d458db into solidity-docs:main Aug 2, 2021
@brunommpreto
Copy link
Collaborator Author

@franzihei I am not able to create a repo within the https://github.com/solidity-docs organization, can you double-check the permissions?

@franzihei
Copy link
Contributor

You should be able to do so now, can you try again @brunommpreto ?

@brunommpreto
Copy link
Collaborator Author

@franzihei I'm still unable to do so
https://i.imgur.com/TUGSvf9.png

The idea is to create another repo within the 'organization' in https://github.com/solidity-docs right? Because that I can't do. I don't have the option to create a new repository. perhaps you can create a new repo within the organization and add me there.

I mean, from what I understood I should create a repo named pt-portuguese within the organization 'solidity-docs' if it is something else, let me know

@franzihei
Copy link
Contributor

I also created this thread in case more coordination is needed: https://forum.soliditylang.org/t/translations-portuguese-coordination-thread/426

@brunommpreto
Copy link
Collaborator Author

@franzihei did you read the previous message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants