Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update POST to server created slug #37

Closed
wants to merge 3 commits into from
Closed

update POST to server created slug #37

wants to merge 3 commits into from

Conversation

bourgeoa
Copy link
Member

@bourgeoa bourgeoa commented Aug 5, 2020

I have implemented :

  • POST with slug server created when resource exists. it uses like NSS uuid.V1
  • to check the result I have added a header slug (it only a way to find the slug created by the server may be deleted)
  • added tests
  • I have renamed back deleteDir to deleteContainer and deleteFile to deleteResource

For my own help I have created a cheat sheet.md to check solid-rest compared to NSS spec implementation.

@jeff-zucker
Copy link
Member

Please pull the existing master before submitting a PR.

to check the result I have added a header slug (it only a way to find the slug created by the server may be deleted)

I do not understand this at all. A POST has to return the new file location in the location header of the response. Why is a slug header needed? Does this slug header exist in NSS?

@jeff-zucker
Copy link
Member

What is the source of the cheatsheet? Is it based on something that NSS uses?

@bourgeoa
Copy link
Member Author

bourgeoa commented Aug 5, 2020

I checked there was no new commit and it was not enough. I shall go to New branches

The header slug is an artefact for the tests. I did not find a way to find the name of the resource created.
Have you any suggestion ?

@bourgeoa
Copy link
Member Author

bourgeoa commented Aug 5, 2020

The cheat cheep should not be kept. It to support discussion.
I should put it in an issue if you agree

Where does it come from ?
It is the result of my understanding from NSS code, consensus on on going spec ( atomic delete) and rising issue ( avoid multiple URL for a resource )

@jeff-zucker
Copy link
Member

Am I correct that this PR #37 was replaced with PR #38 which is now merged? I run 23 tests now and all pass. Thanks so much for your work. If you haven't checked the chat room I have a message for you there.

@jeff-zucker jeff-zucker marked this pull request as draft August 6, 2020 23:18
@jeff-zucker jeff-zucker closed this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants