Add option to disable rocksdb compaction

[sakridge]

Problem

Crashes with rocksdb compaction.
#9009

Summary of Changes

Add option to disable manual compaction.

Fixes #

[brianlong]

This does make sense to me. Currently, compaction is being called within the Rust code AND automatically within RocksDB. Don't need to compact twice. Are you disabling the automated compaction too with this option?

Let me know when you are ready and I can try this branch on my TdS node.

[sakridge]

This does make sense to me. Currently, compaction is being called within the Rust code AND automatically within RocksDB. Don't need to compact twice. Are you disabling the automated compaction too with this option?

Let me know when you are ready and I can try this branch on my TdS node.

That's right, we have both manual and automatic compaction going with the default settings. This flag would just turn off the manual compaction, I'm hoping the automatic compaction is better tested. It seems less aggressive though, so the user would probably need more free disk space.

Pull request has been modified.

[mvines]

One more nit. Rename no_rocks_db_compaction -> no_rocksdb_compaction, and no-rocks-db-compaction -> no-rocksdb-compaction? We don't say rocks db, we say rocksdb.

Pull request has been modified.

[sakridge]

One more nit. Rename no_rocks_db_compaction -> no_rocksdb_compaction, and no-rocks-db-compaction -> no-rocksdb-compaction? We don't say rocks db, we say rocksdb.

Ok, changed to that.