This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fixup sign_transaction; pass derivation_path by reference #8194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garious
reviewed
Feb 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #8194 +/- ##
========================================
+ Coverage 81.4% 81.4% +<.1%
========================================
Files 249 252 +3
Lines 54454 54447 -7
========================================
+ Hits 44335 44350 +15
+ Misses 10119 10097 -22 |
|
@garious , look okay? I'd like to get this merged so I can have a git rev to implement the rust tests in ledger-app-solana |
garious
approved these changes
Feb 11, 2020
mergify bot
pushed a commit
that referenced
this pull request
Feb 11, 2020
* Fixup sign_transaction; pass derivation_path by reference * Pass total message length as BE u16 * Remove live integration tests (to ledger-app-solana) (cherry picked from commit 25d1f84) # Conflicts: # Cargo.lock
CriesofCarrots
added a commit
that referenced
this pull request
Feb 11, 2020
* Fixup sign_transaction; pass derivation_path by reference * Pass total message length as BE u16 * Remove live integration tests (to ledger-app-solana) (cherry picked from commit 25d1f84)
solana-grimes
pushed a commit
that referenced
this pull request
Feb 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://github.com/solana-labs/ledger-app-solana supports blind message signing; let's start sending it transactions!
Summary of Changes
Fixup up LedgerWallet::sign_transaction()` based on ledger-app-solana signing implementation
Plus, a variety of other clean up: