This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Coalesce data and coding index #7765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
force-pushed
the
FixReplayStage3
branch
from
db8660b to
fb86f1b
Compare
pgarg66
previously approved these changes
Jan 12, 2020
carllin
force-pushed
the
FixReplayStage3
branch
from
fb86f1b to
dfcd55b
Compare
Codecov Report
@@ Coverage Diff @@
## master #7765 +/- ##
========================================
- Coverage 81.8% 81.8% -0.1%
========================================
Files 241 241
Lines 50903 50882 -21
========================================
- Hits 41652 41632 -20
+ Misses 9251 9250 -1 |
This was referenced Aug 1, 2022
This was referenced Aug 2, 2022
This was referenced Aug 22, 2022
This was referenced Aug 24, 2022
Open
Open
Open
Open
This was referenced Mar 16, 2024
This was referenced May 22, 2024
This was referenced Oct 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Data and Coding Index structures have the same signature and methods, can be merged into one.
Summary of Changes
Replace DataIndex and CodingIndex with single ShredIndex struct
Fixes #