Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Moves accounts-db test-only code into a dev-context-only-utils feature #32718

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Aug 4, 2023

Problem

To prepare for splitting the runtime crate, we'll need access to some private/test-only functions from accounts-db. To simplify that move, we can consolidate the test-only code within accounts-db into dev-context-only-utils feature blocks.

Summary of Changes

Moves all the test-only code into dev-context-only-utils feature blocks, and update the callers.

Refer to #32169 for more information about dev-context-only-utils.

Note, this diff is large. No actual implementations changed. There is a lot of moving code. There is some changing private to public (but only public within a test-only feature).

@brooksprumo brooksprumo self-assigned this Aug 4, 2023
@brooksprumo brooksprumo force-pushed the accounts-db/dev-context-only-utils branch 3 times, most recently from dc722d6 to 28d32a0 Compare August 4, 2023 19:07
@brooksprumo brooksprumo force-pushed the accounts-db/dev-context-only-utils branch from 28d32a0 to d9bc3cb Compare August 4, 2023 19:28
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #32718 (3fec797) into master (533f42d) will increase coverage by 0.0%.
Report is 2 commits behind head on master.
The diff coverage is 95.4%.

@@           Coverage Diff           @@
##           master   #32718   +/-   ##
=======================================
  Coverage    81.9%    82.0%           
=======================================
  Files         784      784           
  Lines      211004   211002    -2     
=======================================
+ Hits       173012   173022   +10     
+ Misses      37992    37980   -12     

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Aug 21, 2023
@github-actions github-actions bot closed this Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants