Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

programs/sbf: bench running programs with input accounts #30577

Closed

Conversation

alessandrod
Copy link
Contributor

The existing bpf_loader benches execute transactions with only one input account. This PR adds benches with different account configurations (number and size).

@alessandrod alessandrod force-pushed the loader-accounts-benches branch 2 times, most recently from 666dae0 to f1a81ce Compare March 3, 2023 09:18
@alessandrod alessandrod force-pushed the loader-accounts-benches branch from f1a81ce to 80f0e1f Compare March 3, 2023 22:32
@ryoqun
Copy link
Contributor

ryoqun commented Mar 13, 2023

@alessandrod #30602 is just landed. this means you need to rebase this pr. otherwise, you would see these errors after merging (ouch)

error: integer arithmetic detected
   --> benches/bpf_loader_accounts.rs:111:51
    |
111 |     bench_program_execute_read_1_100k_account: 1, 100 * 1024, 1,
    |                                                   ^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#integer_arithmetic
    = note: requested on the command line with `-D clippy::integer-arithmetic`

i know this particular clippy complain is too mundane for bench code. maybe resort to #![allow(clippy::integer_arithmetic)]. On the bright side, this indicates that bad changes to those files will be caught very earlier & very quickly with new test-checks.sh on both ci/laptop.

@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Mar 27, 2023
@github-actions github-actions bot closed this Apr 3, 2023
@alessandrod alessandrod reopened this Apr 10, 2023
@KirillLykov
Copy link
Contributor

this program might be quite useful to test different stages. Can we add it without, probably, using extensively in CI to avoid too long execution? Or we might be interested in having it in another repo, if we must run these CI
@ilya-bobyr

@github-actions github-actions bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 11, 2023
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Apr 26, 2023
@github-actions github-actions bot closed this May 4, 2023
@alessandrod alessandrod reopened this May 4, 2023
@github-actions github-actions bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label May 5, 2023
@github-actions github-actions bot added the stale [bot only] Added to stale content; results in auto-close after a week. label May 19, 2023
@github-actions github-actions bot closed this May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale [bot only] Added to stale content; results in auto-close after a week.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants