Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

set rent epoch to max on new account creation #29528

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

New accounts must be rent exempt. Rent exempt accounts will get rent_epoch=u64::MAX. Rent collection is currently what sets this. At some point we want to turn rent collection off.

Summary of Changes

New account creation will set rent_epoch to u64::MAX.

Fixes #

@jeffwashington jeffwashington marked this pull request as ready for review January 6, 2023 03:21
@jeffwashington jeffwashington changed the title wip: set rent epoch to max on new account creation set rent epoch to max on new account creation Jan 6, 2023
CriesofCarrots
CriesofCarrots previously approved these changes Jan 6, 2023
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I can't think of any gotchas, but it wouldn't hurt to have a second set of eyes on it

runtime/src/accounts.rs Show resolved Hide resolved
@mergify mergify bot dismissed CriesofCarrots’s stale review January 6, 2023 20:12

Pull request has been modified.

@jackcmay
Copy link
Contributor

jackcmay commented Jan 6, 2023

lgtm too

@jeffwashington jeffwashington merged commit 2f0d849 into solana-labs:master Jan 6, 2023
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
* set rent epoch to max on new account creation

* add comment
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
* set rent epoch to max on new account creation

* add comment
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
* set rent epoch to max on new account creation

* add comment
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Jan 10, 2023
* set rent epoch to max on new account creation

* add comment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants