feat: add commission fields matching RPC spec

[R-K-H]

Problem

The @solana/web3.js SDK InflationReward type and rewards in the meta for transaction status metadata object properties do not match the JSON RPC spec in that they are missing the commission field. This is causing an issue with the types when attempting to access field value.

See:

• https://docs.solana.com/developing/clients/jsonrpc-api#getinflationreward
• https://docs.solana.com/developing/clients/jsonrpc-api#getblock

Summary of Changes

Adds the commission field in the src/connection.ts

• InflationReward
• RewardsResult
• GetInflationRewardResult
• BlockResponse
• ParsedBlockResponse
• VersionedBlockResponse
• ConfirmedBlock

Adds commission field in the mockRpcResponse in the tests/connection.test.ts file.

[steveluscher]

[mergify]

automerge label removed due to a CI failure

[steveluscher]

Looks like you have some Typescript errors. Want to fix those up and resubmit, @R-K-H?

Pull request has been modified.

[R-K-H]

Sure thing, I've updated the PR and refactored the previous git commit message to pass lint there as well. I've ran the tests locally with one error from VoteProgram on live test (unrelated I think).

Aside: Looks like it didn't like optional() and since undefined wasn't in the design pattern of current implementation, I just went ahead and continued the pattern for other undefined fields coming from the RPC spec with the null being acceptable.

[steveluscher]

Are you sure this is right? The JSON-RPC docs describe this property as commission: <u8|undefined>.

Suggested change

	commission: number | null;
	commission?: number;

[R-K-H]

You're correct! Will fix.

[steveluscher]

I mean, I'm really just asking. It's a distinct possibility that the docs are wrong. #27655

[R-K-H]

So it is returning null from the request, when doing the live testing it does seem to require that the field is nullable. And I know from my own use that making the request to mainnet the JSON response is returning the commission (at least for InflationReward) as a number.

But I'm fixing right now which I suppose supporting the optional(nullable(number())) more closely matches the JSON RPC spec with it being ABLE to be undefined (although I'm not certain it does return without the field).

[steveluscher]

Allowing for undefined would definitely protect against a response from an old RPC fataling the client. I don't think there are any RPCs old enough to return undefined for this property but ¯_(°ペ)_/¯

[R-K-H]

Indeed and agreed. Updated.

Pull request has been modified.

[codecov]

Codecov Report

Merging #29435 (e24e84c) into master (d392378) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #29435   +/-   ##
=======================================
  Coverage    76.5%    76.5%           
=======================================
  Files          54       54           
  Lines        3129     3129           
  Branches      470      470           
=======================================
  Hits         2396     2396           
  Misses        568      568           
  Partials      165      165