This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Skip loadedAddresses for jsonParsed tx meta #27618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
approved these changes
Sep 6, 2022
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
Skip loaded_addresses for jsonParsed tx meta (cherry picked from commit 1df8830) # Conflicts: # transaction-status/src/lib.rs
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
Skip loaded_addresses for jsonParsed tx meta (cherry picked from commit 1df8830)
CriesofCarrots
pushed a commit
that referenced
this pull request
Sep 7, 2022
Skip loaded_addresses for jsonParsed tx meta (cherry picked from commit 1df8830) # Conflicts: # transaction-status/src/lib.rs
mergify bot
added a commit
that referenced
this pull request
Sep 7, 2022
Skip loadedAddresses for jsonParsed tx meta (#27618) Skip loaded_addresses for jsonParsed tx meta (cherry picked from commit 1df8830) # Conflicts: # transaction-status/src/lib.rs Co-authored-by: Tyera Eulberg <[email protected]>
mergify bot
added a commit
that referenced
this pull request
Sep 7, 2022
Skip loadedAddresses for jsonParsed tx meta (#27618) Skip loaded_addresses for jsonParsed tx meta (cherry picked from commit 1df8830) Co-authored-by: Tyera Eulberg <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now that the
jsonParsedaccounts list includes the account source (transaction or address lookup-table), theloadedAddressesarray is redundant.Summary of Changes
Only return
loadedAddresseswhen other types of encoding are requested.