Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Fail tx sanitization when ix program id uses lookup table #25035

Merged
merged 2 commits into from
May 6, 2022

Conversation

jstarry
Copy link
Contributor

@jstarry jstarry commented May 6, 2022

Problem

Transaction ingestion cannot do static analysis over transaction program instructions to determine user fees, precompile usage, and estimated compute without first loading addresses from on-chain lookup tables.

Summary of Changes

  • Update transaction sanitization to require that tx instructions use static program ids

Fixes #
Feature Gate Issue: #25034

@jstarry jstarry added the feature-gate Pull Request adds or modifies a runtime feature gate label May 6, 2022
@jstarry jstarry requested review from t-nelson and joncinque May 6, 2022 07:53
t-nelson
t-nelson previously approved these changes May 6, 2022
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just nits

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label May 6, 2022
@mergify mergify bot dismissed t-nelson’s stale review May 6, 2022 19:18

Pull request has been modified.

@jstarry jstarry merged commit 082502d into solana-labs:master May 6, 2022
@jstarry jstarry deleted the prohibit-dynamic-program-ids branch May 6, 2022 19:19
@jstarry jstarry added the v1.10 label May 6, 2022
mergify bot pushed a commit that referenced this pull request May 6, 2022
* Fail tx sanitization when ix program id uses lookup table

* feedback

(cherry picked from commit 082502d)

# Conflicts:
#	sdk/src/feature_set.rs
@mergify
Copy link
Contributor

mergify bot commented May 6, 2022

automerge label removed due to a CI failure

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label May 6, 2022
mergify bot added a commit that referenced this pull request May 7, 2022
…25035) (#25052)

* Fail tx sanitization when ix program id uses lookup table (#25035)

* Fail tx sanitization when ix program id uses lookup table

* feedback

(cherry picked from commit 082502d)

# Conflicts:
#	sdk/src/feature_set.rs

* fix conflicts

Co-authored-by: Justin Starry <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants