Prevent log spam by updating channel error type

[carllin]

Problem

#21981 removed the Select channel logic in favor of recv_timeout, so receivers expecting error type for Select are no longer correct

Summary of Changes

Use RecvTimeout errors

Fixes #

[AshwinSekar]

Thanks for the fix!

[behzadnouri]

Just to confirm, the other Error::ReadyTimeout in this file is still good, right?
https://github.com/solana-labs/solana/blob/422a09564/core/src/cluster_info_vote_listener.rs#L596

[carllin]

hehe yeah, looks like this one is still using the Select logic https://github.com/solana-labs/solana/blob/422a09564/core/src/cluster_info_vote_listener.rs#L652

Did you mean to delete the Select logic here as well?

[behzadnouri]

Did you mean to delete the Select logic here as well?

no, just double checking on Error::ReadyTimeout side.

[codecov]

Codecov Report

Merging #22148 (6d11f0c) into master (e1a0660) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #22148     +/-   ##
=========================================
- Coverage    81.2%    81.2%   -0.1%     
=========================================
  Files         520      520             
  Lines      145949   145949             
=========================================
- Hits       118534   118533      -1     
- Misses      27415    27416      +1