Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

adds ShredId uniquely identifying each shred #21820

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

behzadnouri
Copy link
Contributor

Problem

(slot, shred_index, shred_type) scattered through out the code for identifying shreds.

Summary of Changes

added ShredId type for uniquely identifying shreds.

@codecov
Copy link

codecov bot commented Dec 12, 2021

Codecov Report

Merging #21820 (4b237bb) into master (033106e) will decrease coverage by 0.0%.
The diff coverage is 95.3%.

@@            Coverage Diff            @@
##           master   #21820     +/-   ##
=========================================
- Coverage    81.3%    81.2%   -0.1%     
=========================================
  Files         516      516             
  Lines      144217   144226      +9     
=========================================
- Hits       117268   117249     -19     
- Misses      26949    26977     +28     

carllin
carllin previously approved these changes Dec 13, 2021
@mergify mergify bot dismissed carllin’s stale review December 14, 2021 14:12

Pull request has been modified.

@behzadnouri behzadnouri merged commit 4ceb268 into solana-labs:master Dec 14, 2021
@behzadnouri behzadnouri deleted the shred-id branch December 14, 2021 17:34
mergify bot pushed a commit that referenced this pull request Dec 14, 2021
(cherry picked from commit 4ceb268)

# Conflicts:
#	ledger/src/blockstore.rs
mergify bot added a commit that referenced this pull request Dec 14, 2021
* adds ShredId uniquely identifying each shred (#21820)

(cherry picked from commit 4ceb268)

# Conflicts:
#	ledger/src/blockstore.rs

* removes backport merge conflicts

Co-authored-by: behzad nouri <[email protected]>
@brooksprumo brooksprumo mentioned this pull request Jan 5, 2022
mergify bot pushed a commit that referenced this pull request Feb 4, 2022
(cherry picked from commit 4ceb268)

# Conflicts:
#	ledger/src/blockstore.rs
mergify bot added a commit that referenced this pull request Feb 4, 2022
* adds ShredId uniquely identifying each shred (#21820)

(cherry picked from commit 4ceb268)

# Conflicts:
#	ledger/src/blockstore.rs

* removes mergify merge conflicts

Co-authored-by: behzad nouri <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants