This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add address lookup table program #21616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
address-lookup-table-program
branch
3 times, most recently
from
98fa440 to
0b444db
Compare
jstarry
force-pushed
the
address-lookup-table-program
branch
from
0b444db to
34d4ebb
Compare
jstarry
requested review from
lijunwangs and
joncinque
and removed request for
lijunwangs
joncinque
reviewed
Dec 10, 2021
jstarry
commented
Dec 10, 2021
Comment on lines
+293
to
+304
| { | ||
| let mut lookup_table_account_ref_mut = lookup_table_account.try_account_ref_mut()?; | ||
| AddressLookupTable::overwrite_meta_data( | ||
| lookup_table_account_ref_mut.data_as_mut_slice(), | ||
| lookup_table_meta, | ||
| )?; | ||
|
|
||
| let table_data = lookup_table_account_ref_mut.data_mut(); | ||
| for new_address in new_addresses { | ||
| table_data.extend_from_slice(new_address.as_ref()); | ||
| } | ||
| } |
There was a problem hiding this comment.
This block changed in the latest commit. Rather than allocating a new account data vector, this tries to modify the AccountSharedData data vector directly if it isn't already referenced somewhere.
Codecov Report
@@ Coverage Diff @@
## master #21616 +/- ##
=========================================
- Coverage 81.6% 81.4% -0.2%
=========================================
Files 511 515 +4
Lines 143320 143691 +371
=========================================
+ Hits 116976 117099 +123
- Misses 26344 26592 +248 |
joncinque
approved these changes
Dec 10, 2021
Comment on lines
+293
to
+304
| { | ||
| let mut lookup_table_account_ref_mut = lookup_table_account.try_account_ref_mut()?; | ||
| AddressLookupTable::overwrite_meta_data( | ||
| lookup_table_account_ref_mut.data_as_mut_slice(), | ||
| lookup_table_meta, | ||
| )?; | ||
|
|
||
| let table_data = lookup_table_account_ref_mut.data_mut(); | ||
| for new_address in new_addresses { | ||
| table_data.extend_from_slice(new_address.as_ref()); | ||
| } | ||
| } |
mergify bot
pushed a commit
that referenced
this pull request
Dec 10, 2021
* Add address lookup table program * feedback (cherry picked from commit 9b41ddd) # Conflicts: # runtime/Cargo.toml
mergify bot
added a commit
that referenced
this pull request
Dec 11, 2021
* Add address lookup table program (#21616) * Add address lookup table program * feedback (cherry picked from commit 9b41ddd) # Conflicts: # runtime/Cargo.toml * resolve conflicts Co-authored-by: Justin Starry <[email protected]>
Closed
65 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users and protocols need a way to store addresses on-chain for transaction v2 address lookups.
Summary of Changes
256since transaction v2 account indices are typed asu8Implements the amended proposal here: #21576