Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Refactor: Unifies ThisInvokeContext and dyn trait InvokeContext. #21563

Conversation

Lichtso
Copy link
Contributor

@Lichtso Lichtso commented Dec 2, 2021

Problem

ThisInvokeContext is the only impl of trait InvokeContext

Summary of Changes

  • Removes trait InvokeContext
  • Renames ThisInvokeContext to InvokeContext
  • Marks all ThisInvokeContext methods as pub and copies their doc comments from trait InvokeContext
  • Adjusts the lifetimes of InvokeContext references.

Fixes #

@Lichtso Lichtso force-pushed the refactor/remove_dyn_trait_from_invoke_context branch from 367b5f2 to c69cad3 Compare December 2, 2021 13:42
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #21563 (c69cad3) into master (c825b0a) will decrease coverage by 0.0%.
The diff coverage is 85.4%.

@@            Coverage Diff            @@
##           master   #21563     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         506      506             
  Lines      142368   142266    -102     
=========================================
- Hits       116232   116134     -98     
+ Misses      26136    26132      -4     

@Lichtso Lichtso merged commit bfdb775 into solana-labs:master Dec 2, 2021
@Lichtso Lichtso deleted the refactor/remove_dyn_trait_from_invoke_context branch December 2, 2021 17:47
@Lichtso Lichtso mentioned this pull request Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant