This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Refactor: Remove program_id from process_instruction() #20540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/remove_program_id_from_process_instruction
branch
from
b1bbb5d to
d688fb2
Compare
Lichtso
force-pushed
the
refactor/remove_program_id_from_process_instruction
branch
from
d688fb2 to
ac461f8
Compare
Lichtso
force-pushed
the
refactor/remove_program_id_from_process_instruction
branch
from
ac461f8 to
68982a3
Compare
Lichtso
force-pushed
the
refactor/remove_program_id_from_process_instruction
branch
from
68982a3 to
4e9909f
Compare
Lichtso
force-pushed
the
refactor/remove_program_id_from_process_instruction
branch
from
4e9909f to
655bfe2
Compare
Lichtso
force-pushed
the
refactor/remove_program_id_from_process_instruction
branch
from
655bfe2 to
ecf83c7
Compare
Codecov Report
@@ Coverage Diff @@
## master #20540 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 494 494
Lines 137478 137480 +2
=========================================
- Hits 112804 112796 -8
- Misses 24674 24684 +10 |
Lichtso
deleted the
refactor/remove_program_id_from_process_instruction
branch
Closed
dankelleher
pushed a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…0540) * Replaces usage of program_id parameter by invoke_context.get_caller()?. * Removes "pubkey: &Pubkey" parameter from "process_instruction()".
frits-metalogix
added a commit
to identity-com/solana
that referenced
this pull request
Nov 24, 2021
…a-labs#20540)" This reverts commit aa24141.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The parameter
program_id: &Pubkeyis redundant as it is stored inInvokeContext::invoke_stackanyway.Summary of Changes
Removes the parameter
program_id: &Pubkeyfromprocess_instruction().Fixes #