This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Store versioned transactions in the ledger, disabled by default #19139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jstarry
changed the title
jstarry
force-pushed
the
versioned-tx
branch
3 times, most recently
from
ed19033 to
4c035f9
Compare
t-nelson
reviewed
Aug 14, 2021
jstarry
force-pushed
the
versioned-tx
branch
2 times, most recently
from
3d0daec to
1ee709f
Compare
t-nelson
previously approved these changes
Aug 17, 2021
jstarry
commented
Aug 17, 2021
Comment on lines
+54
to
+57
| let sanitized_msg = Self::Legacy(message); | ||
| if sanitized_msg.has_duplicates() { | ||
| return Err(SanitizeMessageError::DuplicateAccountKey); | ||
| } |
There was a problem hiding this comment.
fyi @t-nelson I just added this forgotten dupe check which is currently inconsequential but could have caused issues later
jstarry
added
the
feature-gate
65 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ledger cannot store versioned transactions
Summary of Changes
Most of the following changes are groundwork needed for enabling the processing of the new versioned transactions and aren't too interesting:
SanitizedTransactionandSanitizedMessageover the legacy versions since these new structs will wrap both legacy and versioned transactions and messages, respectively.The most significant changes in this PR are in
solana-sdkand involve:MappedMessagestruct which wraps the new v0 message along with a list of its mapped messages. This struct provides methods to retrieve the full list of message accounts (including the accounts loaded by mapped addresses).SanitizedMessagestruct which wraps the legacyMessageand the newMappedMessageand adopts a large portion of the legacyMessagefor compatibility across the runtime.VersionedMessagewhich mirror some of the legacyMessagemethods used for verification and hashing before the message is sanitized.SanitizedTransactionstruct which has now replaced the majority of the usages of legacyTransactionacross the runtime.VersionedTransactionstruct which is what is now serialized into each ledgerEntryinstead of legacy transactions. It has a small API since it has limited usage before the runtime converts it into aSanitizedTransactionFeature Gate Issue: #24047