This repository has been archived by the owner on Jan 22, 2025. It is now read-only.
Add db recovery methods #10838
Merged
Add db recovery methods #10838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
wal-recovery-flag
branch
5 times, most recently
from
440bf9e to
76e0668
Compare
Codecov Report
@@ Coverage Diff @@
## master #10838 +/- ##
=========================================
- Coverage 82.0% 81.9% -0.1%
=========================================
Files 310 310
Lines 71884 71906 +22
=========================================
+ Hits 58949 58955 +6
- Misses 12935 12951 +16 |
mvines
reviewed
Jun 30, 2020
sakridge
force-pushed
the
wal-recovery-flag
branch
from
76e0668 to
96028d1
Compare
sakridge
force-pushed
the
wal-recovery-flag
branch
from
96028d1 to
da1838f
Compare
t-nelson
reviewed
Jul 2, 2020
t-nelson
previously approved these changes
Jul 2, 2020
There was a problem hiding this comment.
LGTM! Just one nit
FYI, there's a DB to test this against on ba3, #10015 (comment)
sakridge
force-pushed
the
wal-recovery-flag
branch
from
da1838f to
f87189e
Compare
Cool, I added the option to solana-ledger-tool and also implemented |
sakridge
force-pushed
the
wal-recovery-flag
branch
from
f87189e to
b96180d
Compare
sakridge
force-pushed
the
wal-recovery-flag
branch
from
b96180d to
a22aab0
Compare
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Aug 9, 2020
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Aug 9, 2020
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Aug 10, 2020
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Aug 10, 2020
sakridge
added a commit
that referenced
this pull request
Aug 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Blockstore encounters errors opening the db because wal/sst corruption.
Summary of Changes
Allow for skipping corrupted wal entries.
Fixes #10015