Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Interleaved snapshot untar/rebuilding - Versioning #27346

Closed
apfitzge opened this issue Aug 23, 2022 · 0 comments · Fixed by #27484
Closed

Interleaved snapshot untar/rebuilding - Versioning #27346

apfitzge opened this issue Aug 23, 2022 · 0 comments · Fixed by #27484
Assignees

Comments

@apfitzge
Copy link
Contributor

Problem

With #26590 we introduced snapshot rebuilding logic that relies on the version being 1.2 before we know that that's the case.

#27192 serializes the version file first, but we need to wait until that's rolled out before we can add version checking to code from #26590.

Proposed Solution

Deserialize version file before we start rebuilding (blocked by #27192 rollout) and pass the version up from there. This will allow us to rebuild from different versions while still unpacking/rebuilding in parallel

@apfitzge apfitzge self-assigned this Aug 23, 2022
apfitzge added a commit to apfitzge/agave that referenced this issue Aug 30, 2022
apfitzge added a commit that referenced this issue Sep 22, 2022
* Issue #27346 - deserialize and check snapshot version before account fields

* Update comment on SnapshotFileKind

Co-authored-by: Brooks Prumo <[email protected]>

* SnapshotStorageRebuilderResult to RebuiltSnapshotStorage

* better error propagation from rebuild_storage

Co-authored-by: apfitzge <[email protected]>
Co-authored-by: Brooks Prumo <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant