Skip to content
This repository was archived by the owner on Mar 29, 2023. It is now read-only.

more refactoring #7

Merged
merged 17 commits into from
Nov 5, 2021
Merged

more refactoring #7

merged 17 commits into from
Nov 5, 2021

Conversation

jordaaash
Copy link
Contributor

@jordaaash jordaaash commented Nov 1, 2021

Continued from #5

To do

  • Uncomment or remove all commented out blocks of executable code
  • Refactor out clone method
  • Document all public methods in more detail
  • Address all remaining TODO/FIXME comments
  • Revamp error types
  • Colocate unit and integration tests
  • Remove Makefile and use yarn scripts + shx (platform-indepedent and JS devs are more familiar with)
  • Finish ES modules configuration

@jordaaash jordaaash marked this pull request as draft November 1, 2021 02:46
@jordaaash jordaaash mentioned this pull request Nov 1, 2021
@jordaaash
Copy link
Contributor Author

I ran into issues using ES modules with the example in the readme, which expects commonjs to work. It might be better to just use commonjs for now until proper build tooling is set up.

@jordaaash jordaaash marked this pull request as ready for review November 5, 2021 15:44
@jordaaash jordaaash changed the title DRAFT: more refactoring more refactoring Nov 5, 2021
@jordaaash jordaaash merged commit 52c711d into master Nov 5, 2021
@jordaaash jordaaash mentioned this pull request Nov 5, 2021
17 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant